Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve balance api #879

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Improve balance api #879

merged 2 commits into from
Feb 1, 2023

Conversation

samuelmanzanera
Copy link
Member

Description

Add the resolution of the last address in the get_balance api

Fixes #875

Type of change

Please delete options that are not relevant.

  • Enhancement

How Has This Been Tested?

The API should fetch the balance from:

  • a genesis address
  • a transaction
  • the latest transaction of a chain

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added API Involve API facing user enhancements labels Jan 31, 2023
@Neylix Neylix merged commit f8dfd04 into develop Feb 1, 2023
@Neylix Neylix deleted the improve_balance_api branch February 1, 2023 14:30
@samuelmanzanera samuelmanzanera added feature New feature request and removed enhancements labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenmoves tenmoves tenmoves approved these changes

@Neylix Neylix Neylix approved these changes

Assignees
No one assigned
Labels
API Involve API facing user feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the get_balance query to fetch the inputs if there is not existing transaction
3 participants
@samuelmanzanera @tenmoves @Neylix