Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEWeb: if url is a folder and there is an index.html inside, serve the index.html #874 #889

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Feb 6, 2023

Description

If there is no index.html in the root folder , we host website as a navigation, but if we go inside any folder and if we encounter a index.html we should host it/ render it instead of rendering as navigation/explorer.

Fixes

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • manual testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 changed the title Host index.html, if dir contains it AEWeb: if url is a folder and there is an index.html inside, serve the index.html #874 Feb 7, 2023
@apoorv-2204 apoorv-2204 marked this pull request as ready for review February 7, 2023 08:42
@samuelmanzanera samuelmanzanera merged commit d3a77f8 into archethic-foundation:develop Feb 8, 2023
@samuelmanzanera samuelmanzanera added the feature New feature request label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AEWeb: if url is a folder and there is an index.html inside, serve the index.html
3 participants