Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create appup transform to set post_purge to soft #897

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 7, 2023

Description

Create new module Archethic.Release.TransformPurge.
This module is called during the creation of an appup from distillery.
It is configured in rel/config.exs

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Create a release on testnet branch using ./script/test-script.sh -i
Switch to PR branch, change mix.exs version and generate an appup using mix distillery.gen.appup --app archethic
The generated appup should have brutal_purge and soft_purge in each load_module or update instructions.
Generate the upgrade release using ./script/test-release.sh -p it should take the generated appup as it valid (not create a new one, visible in log)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added dependencies Pull requests that update a dependency file enhancements labels Feb 7, 2023
@samuelmanzanera samuelmanzanera merged commit 7be86b0 into archethic-foundation:develop Feb 8, 2023
@Neylix Neylix deleted the Add-appup-transform branch February 28, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants