Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take previous reward address in node bootstrap #916

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

samuelmanzanera
Copy link
Member

Description

This PR fetch the last reward address to include it into the new node transactions.

Fixes #909

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

You need to start at least 2 or more nodes.
You need to alter the reward address located in the settings page: /settings
You have to stop the node, and wait the out of sync threshold to force a new transaction of the node's chain (ie. 1 min)
You can restart the node, and it should create a new transaction with the changed reward address.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working API Involve API facing user bootstrap labels Feb 27, 2023
Copy link
Contributor

@tenmoves tenmoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the method described everything seems fine !

@Neylix Neylix merged commit c915fa7 into develop Feb 28, 2023
@Neylix Neylix deleted the integrate_previous_reward branch February 28, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user bootstrap bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use previous reward address when sending node transaction
3 participants