Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance_validation_of_keychain_keychain_access_transaction_#882 #932

Conversation

apoorv-2204
Copy link
Contributor

Description

We want to avoid ddos of keychain tx and keychain access due to being free.

image
image by @Neylix

Fixes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 force-pushed the Enhance_validation_of_keychain_keychain_access_transaction_#882 branch from 1cff983 to 496b009 Compare March 15, 2023 04:37
@apoorv-2204 apoorv-2204 self-assigned this Mar 15, 2023
@apoorv-2204 apoorv-2204 marked this pull request as ready for review March 15, 2023 04:37
@samuelmanzanera
Copy link
Member

Otherwise good PR ;)

@apoorv-2204 apoorv-2204 force-pushed the Enhance_validation_of_keychain_keychain_access_transaction_#882 branch 2 times, most recently from 64d12ed to 34c320a Compare March 16, 2023 12:32
@apoorv-2204 apoorv-2204 force-pushed the Enhance_validation_of_keychain_keychain_access_transaction_#882 branch from 34c320a to b103468 Compare March 16, 2023 13:10
@samuelmanzanera samuelmanzanera merged commit eb76d8d into archethic-foundation:develop Mar 17, 2023
@samuelmanzanera samuelmanzanera linked an issue Mar 17, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance validation of keychain & keychain access transaction
2 participants