Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Rolling" SelfRepair #933

Merged
merged 46 commits into from
Apr 26, 2023
Merged

"Rolling" SelfRepair #933

merged 46 commits into from
Apr 26, 2023

Conversation

bchamagne
Copy link
Member

Description

Maintain a NetworkView that is used to detect synchronization issue between welcome node & validation nodes.
When a desynchronization is detected, start the relevant synchronization (either P2P, or the network chains)

Fixes #912

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested multiple scenarios:

  • welcome node is not sync (tx is forwarded)
  • 1 validation node is not sync (tx is forwarded)
  • 2 validation nodes are not sync (tx pass)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added feature New feature request mining Involve transaction validation and mining labels Mar 13, 2023
samuelmanzanera
samuelmanzanera reviewed Mar 14, 2023
View reviewed changes
lib/archethic.ex Outdated Show resolved Hide resolved
samuelmanzanera
samuelmanzanera reviewed Mar 16, 2023
View reviewed changes
lib/archethic.ex Outdated Show resolved Hide resolved
@samuelmanzanera
Copy link
Member

Nice PR !

Neylix
Neylix requested changes Mar 21, 2023
View reviewed changes
lib/archethic/self_repair.ex Outdated Show resolved Hide resolved
lib/archethic/self_repair.ex Outdated Show resolved Hide resolved
lib/archethic/self_repair.ex Outdated Show resolved Hide resolved
lib/archethic/self_repair/network_view.ex Outdated Show resolved Hide resolved
lib/archethic/self_repair/network_view.ex Outdated Show resolved Hide resolved
lib/archethic/self_repair/network_view.ex Outdated Show resolved Hide resolved
lib/archethic/p2p/message/start_mining.ex Outdated Show resolved Hide resolved
lib/archethic/self_repair/network_view.ex Outdated Show resolved Hide resolved
Neylix
Neylix requested changes Apr 5, 2023
View reviewed changes
lib/archethic/self_repair/network_chain.ex Outdated Show resolved Hide resolved
@Neylix Neylix merged commit c96d074 into archethic-foundation:develop Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmanzanera samuelmanzanera samuelmanzanera approved these changes

@Neylix Neylix Neylix approved these changes

Assignees

@bchamagne bchamagne

Labels
feature New feature request mining Involve transaction validation and mining
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constantly re synchonize network transactions
3 participants
@bchamagne @samuelmanzanera @Neylix