New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conditionInterpreter v0 comparaison #961

Merged

Neylix merged 3 commits into archethic-foundation:develop from bchamagne:918-interpreter-v0-boolean-expression-bug

Apr 3, 2023

Member

bchamagne commented Mar 29, 2023

Description

<, > were not generating proper code.
Fixes #918

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

add unit test

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules


          fix conditionInterpreter v0 comparaison

e095f44

bchamagne added bug smart contracts labels

bchamagne self-assigned this

bchamagne and others added 2 commits

March 29, 2023 10:47


          fix legacy interpreter doctest

221817d


          Add test to ensure condition return false

94de65a

Neylix approved these changes

View reviewed changes

Neylix merged commit c4dfaad into archethic-foundation:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment