Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contract: is_function_call? bug #987

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

bchamagne
Copy link
Member

Description

Some SC were not parsing such as the one I added in the test suite.
This happened because there was a pattern match [_] on alias. This is wrong, an alias can be of any size (e.g. [:Archethic, :Contracts, :Interpreter, :Library, :Contract])

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test added.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added smart contracts Involve smart contracts bug Something isn't working labels Apr 21, 2023
@Neylix Neylix merged commit a5aaf17 into archethic-foundation:develop Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants