Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contracts playbooks rework #994

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

bchamagne
Copy link
Member

@bchamagne bchamagne commented Apr 24, 2023

Description

Freshen up the smart contract playbooks.
They are easier to write, easier to read and the logs are easier on the eyes.
Add 3 new test contracts:

  1. Faucet
  2. Counter
  3. UCO All-Time High

Depends on #995 (Json.parse function)
Fixes #929

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Start a local node and then run mix archethic.regression --playbook localhost.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added smart contracts Involve smart contracts testing Improve testing labels Apr 24, 2023
@bchamagne bchamagne changed the title Smart Contracts Playbooks Smart Contracts playbooks rework Apr 24, 2023
@samuelmanzanera samuelmanzanera added this to the v.1.0.8-rc2 milestone May 3, 2023
lib/archethic/contracts/interpreter/action_interpreter.ex Outdated Show resolved Hide resolved
lib/archethic/contracts/worker.ex Outdated Show resolved Hide resolved
lib/archethic/contracts/worker.ex Outdated Show resolved Hide resolved
lib/archethic/utils/regression/playbooks/smart_contract.ex Outdated Show resolved Hide resolved
lib/archethic/utils/regression/playbooks/smart_contract.ex Outdated Show resolved Hide resolved
@bchamagne bchamagne marked this pull request as draft May 4, 2023 15:01
@bchamagne
Copy link
Member Author

I'm going to remove all the fixes from this PR and open a PR for each fix. Because we want the fixes in 1.0.8 and this PR require more work to be complete

@bchamagne bchamagne removed this from the v.1.0.8-rc2 milestone May 5, 2023
@bchamagne bchamagne force-pushed the 929-sc-playbooks branch 4 times, most recently from 64885c1 to a5c3473 Compare May 10, 2023 08:36
@samuelmanzanera samuelmanzanera added this to the 1.2.0 milestone May 10, 2023
@bchamagne bchamagne mentioned this pull request May 11, 2023
@bchamagne bchamagne removed this from the 1.2.0 milestone Jun 14, 2023
@bchamagne
Copy link
Member Author

Depends on #1124. It cannot work without it.

@bchamagne bchamagne marked this pull request as ready for review June 27, 2023 14:27
@bchamagne bchamagne added this to the 1.3.0 milestone Jun 27, 2023
@bchamagne bchamagne removed this from the 1.3.0 milestone Aug 29, 2023
@Neylix Neylix force-pushed the 929-sc-playbooks branch 3 times, most recently from f51b881 to 08a1a58 Compare September 19, 2023 12:27
@bchamagne bchamagne merged commit ace44a7 into archethic-foundation:develop Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smart contracts Involve smart contracts testing Improve testing
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

Improve playbooks with smart contract examples
3 participants