Add serialization padding

archethic-foundation · Oct 17, 2023 · ad935bc · ad935bc
1 parent c450946
commit ad935bc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/transaction_builder.ts b/src/transaction_builder.ts
@@ -11,10 +11,8 @@ import {
     bigIntToUint8Array,
     concatUint8Arrays,
     intToUint8Array,
-    isObject,
     maybeHexToUint8Array,
     maybeStringToUint8Array,
-    sortObjectKeysASC,
     toByteArray,
     uint8ArrayToHex
 } from "./utils.js";
@@ -334,14 +332,14 @@ export default class TransactionBuilder {
             )
         })
 
-        const ucoTransfersBuffers = this.data.ledger.uco.transfers.map(function (transfer) {
+        const ucoTransfersBuffers = this.data.ledger.uco.transfers.map(function(transfer) {
             return concatUint8Arrays(
                 transfer.to,
                 bigIntToUint8Array(transfer.amount)
             )
         })
 
-        const tokenTransfersBuffers = this.data.ledger.token.transfers.map(function (transfer) {
+        const tokenTransfersBuffers = this.data.ledger.token.transfers.map(function(transfer) {
             const bufTokenId = toByteArray(transfer.tokenId)
             return concatUint8Arrays(
                 transfer.tokenAddress,
@@ -370,6 +368,8 @@ export default class TransactionBuilder {
                     // action
                     Uint8Array.from([action.length]),
                     new TextEncoder().encode(action),
+                    // padding = 0
+                    Uint8Array.from([0]),
                     // args count
                     Uint8Array.from([serializedArgs.length]),
                     // args

diff --git a/tests/transaction_builder.test.ts b/tests/transaction_builder.test.ts
@@ -398,6 +398,8 @@ describe("Transaction builder", () => {
                 Uint8Array.from([14]),
                 // action value
                 new TextEncoder().encode("vote_for_mayor"),
+                // padding = 0
+                Uint8Array.from([0]),
                 // args size
                 Uint8Array.from([1]),
                 // args value
@@ -457,6 +459,8 @@ describe("Transaction builder", () => {
                 Uint8Array.from([10]),
                 // action value
                 new TextEncoder().encode("set_geopos"),
+                // padding = 0
+                Uint8Array.from([0]),
                 // args size
                 Uint8Array.from([1]),
                 // args value