New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruby "remove top-level constant lookup" issue #5

Merged

archfish merged 3 commits into archfish:master from wppurking:master

Mar 5, 2020

Contributor

wppurking commented Mar 4, 2020

ruby 2.5 has removed top level constant lookup. so when use URI.parse in ruby 2.5+ will raise NameError: uninitialized constant URI.

to fix this:

require the uri module
use ::URI instead of URI

wppurking added 3 commits

March 4, 2020 16:04


          add rake as development dependency to use "rake install/release"

ad5797b


          ignore Intellij IDEA project file to git

9ef2ce3


          need require 'url' module and fix https://bugs.ruby-lang.org/issues/1…

f2c6bfc

…1547 in constant lookup

archfish merged commit af3543d into archfish:master

Owner

archfish commented Mar 5, 2020

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet