#240: Fix commandTimings failing when before hooks are logged.

README.md

@@ -370,6 +370,8 @@ directory. You should add `it.only` to the test case you are working on to speed
 ## Release Notes
 
 - Fix `never` on `printLogsToConsole` works in all cases. [issue](https://github.com/archfz/cypress-terminal-report/issues/241)
+- Fix `commandTimings` failing when before hooks are logged. [issue](https://github.com/archfz/cypress-terminal-report/issues/240)
+- `commandTimings` now log the time elapsed since the suite / spec start instead of the time since the test start.
 
 #### 6.0.1
 

src/collector/LogCollectorState.js

@@ -11,7 +11,7 @@ module.exports = class LogCollectorState {
     this.beforeHookIndexes = [];
     this.afterHookIndexes = [];
     this.isStrict = false;
-    this.testStartTime = null;
+    this.suiteStartTime = null;
   }
 
   setStrict(strict) {
@@ -79,7 +79,7 @@ module.exports = class LogCollectorState {
       if (this.config.commandTimings == 'timestamp') {
         structuredEntry.timeString = Date.now() + "";
       } else if (this.config.commandTimings == 'seconds') {
-        structuredEntry.timeString = (Date.now() - this.testStartTime.getTime()) / 1000 + "s";
+        structuredEntry.timeString = (Date.now() - this.suiteStartTime.getTime()) / 1000 + "s";
       }
     }
     if (xhrIdOfLoggedResponse) {
@@ -155,6 +155,7 @@ module.exports = class LogCollectorState {
     if (this.config.debug) {
       console.log(CONSTANTS.DEBUG_LOG_PREFIX + 'starting suite');
     }
+    this.suiteStartTime = new Date();
     this.xhrIdsOfLoggedResponses = [];
     this.beforeHookIndexes.unshift(0);
     this.afterHookIndexes.unshift(0);
@@ -172,7 +173,6 @@ module.exports = class LogCollectorState {
     }
     this.setCurrentTest(test);
     this.xhrIdsOfLoggedResponses = [];
-    this.testStartTime = new Date();
 
     this.addNewLogStack();
 

test/package.json

@@ -28,7 +28,7 @@
     "@bahmutov/cypress-esbuild-preprocessor": "^2.2.0",
     "babel-loader": "^9.1.3",
     "chai": "^4.2.0",
-    "cypress": "13.6.1",
+    "cypress": "13.8.1",
     "@cypress/grep": "^4.0.1",
     "fs-extra": "^10.1.0",
     "glob": "^8.0.3",

test/specs/misc.spec.js

@@ -142,4 +142,10 @@ describe('Misc.', () => {
     });
   }).timeout(60000);
 
+  it('Should log command times in seconds with extended collector and before hooks.', async function () {
+    await runTest(commandBase(['commandTimings=seconds', 'enableExtendedCollector=1'], ['beforeLogs.spec.js']), (error, stdout, stderr) => {
+      expect(clean(stdout, true)).to.match(/Time: \d+\.\d{3}s\n      cy:command/);
+    });
+  }).timeout(60000);
+
 });