Type definitions export ES Modules but should export CommonJS

[OliverJAsh]

Reduced test case: https://github.com/OliverJAsh/cypress-10-cypress-terminal-report-errors

This is a brand new Cypress project.

Run yarn and then tsc.

❯ tsc
cypress.config.js:7:13 - error TS2349: This expression is not callable.
  Type 'typeof import("/Users/oliverash/Development/temp/cypress-10-cypress-terminal-report-errors/node_modules/cypress-terminal-report/src/installLogsPrinter")' has no call signatures.

7             enableTerminalReportLogsPrinter(on);
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in cypress.config.js:7

This is happening because the type definitions are defined using ES Modules (export default installLogsPrinter;) however they should be defined as CommonJS (export = installLogsPrinter;) to match the JS source code.

cypress-terminal-report/src/installLogsPrinter.d.ts

Line 113 in c7d74ce

export default installLogsPrinter;

cypress-terminal-report/src/installLogsPrinter.js

Line 324 in c7d74ce

module.exports = installLogsPrinter;

https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require

Related change: 59f0ab9#diff-2a909c3c7c488c66f7e2c41d5b33f5c0f062d164a5a5e47485318e0697a0d7adL87

Related issue: #149

[archfz]

Please check step 2 from install part of readme.

Based on that I think this duplicates #148

[OliverJAsh]

esModuleInterop is already enabled in the reduced test case https://github.com/OliverJAsh/cypress-10-cypress-terminal-report-errors/blob/67f6a73665790988aedd108494be1ee8b6b63022/tsconfig.json#L6

[archfz]

Can you please check the demo project from readme, using this plugin? That is also with typescript and it's working. Check for difference against your setup.

[OliverJAsh]

The difference is the Cypress config file in your demo uses ES imports: https://github.com/archfz/cypress-terminal-report-demo/blob/7d3c107bf102d0280b01431b3f518c5169561f73/cypress.config.ts#L2

Whereas the config file in my reduced test case is using a CommonJS require: https://github.com/OliverJAsh/cypress-10-cypress-terminal-report-errors/blob/67f6a73665790988aedd108494be1ee8b6b63022/cypress.config.js#L2

I think this tool should support config files with CommonJS as this is supported by Cypress. I have explained a way to fix this above.

[archfz]

Ok thank you. PRs are welcome btw.

[archfz]

Released fix in 4.0.2. Please test.

[drebrez]

Hi @archfz ,

I've just noticed that this problem also applies to the installLogsCollector.

In commit 743b551 you fixed it only for the installLogsPrinter.

I've created a PR with the fix #167