Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure passing --port (and --host) work in HTTP mode #178

Closed
ryanblock opened this issue Sep 5, 2023 · 3 comments · May be fixed by #179
Closed

Ensure passing --port (and --host) work in HTTP mode #178

ryanblock opened this issue Sep 5, 2023 · 3 comments · May be fixed by #179
Assignees
@ryanblock
Labels
invalid

Comments

@ryanblock
Copy link
Member

Currently, --port (and --host) for Dynalite do not work in CLI mode, as they're only passed when creating an HTTPS server (see: #176 (comment)). Easy fix!
@ryanblock ryanblock added the bug label Sep 5, 2023
@ryanblock ryanblock self-assigned this Sep 5, 2023
ryanblock added a commit that referenced this issue Sep 5, 2023
@ryanblock
Drop use of self-signed certs (which are now expired), fixes #176
3bd330d 
Add `--key`, `--cert`, `--ca` CLI flags, and `useSSLFilePaths` API option
Only require `http` or `https`, but not both
Update types
Fix `--port` + `--host` not being passed in `http` mode; fixes #178
@ryanblock ryanblock mentioned this issue Sep 5, 2023
Open
8 tasks
@mhart
Copy link
Collaborator

mhart commented Sep 6, 2023

Wait, really? Something must be up if that's true – both port and host are separate to the SSL option: https://github.com/architect/dynalite/blob/main/cli.js#L34-L39

@ryanblock ryanblock added invalid and removed bug labels Sep 6, 2023
@ryanblock
Copy link
Member Author

@mhart yeah, you are correct, this issue is invalid. I conflated a couple diff paths in here (passing in options vs. the ability to pass these same options to server.listen()). Marking invalid, ty!

@ryanblock
Copy link
Member Author

Updated changelog here to better describe what was going on! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanblock ryanblock

Labels
invalid
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop use of self-signed certs (which are now expired), fixes #176 architect/dynalite
2 participants
@ryanblock @mhart