Data validation for inputs in front end #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reyery I wonder if we should be using |
|
@daren-thomas maybe let's open a new issue to move inputs.yml to schemas.yml to a separated issue. #2480 |
|
@reyery @jimenofonseca as far as I can tell, this can be merged - it's what I presented at the demo. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a way to implement input validation for the front end, which helps with #2310 and #2141
It introduces a new property constraints for fields in input.yaml, which could be used to specify the range of the field i.e. max.
A new field type choice is also added to restrict users to only select values found in a list.
A property location is used to extract this list of values from a database.
Other Changes:
Update
technical_systemstoair_conditioning_systems