New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pythonocc to enable Mac ARM support #3265
Conversation
We paused merging this PR for now until @reyery figure it out what to do with it. |
Not sure if this can be merged since the results for the thermal networks is very different due to changes to @jimenofonseca maybe you can take a look at the differences and see if it makes sense. I attached the outputs in the zip file |
@MatNif maybe you have some ideas as well. Apparently one of the changes in Pressure losses of edges seems to differ by 10^-3 https://wntr.readthedocs.io/en/latest/whatsnew.html#v0-3-0-november-2-2020 |
I have tried recompiling @MatNif the EPANET version used in @ShiZhongming It now works for Apple Silicon Macs natively, it should be a little faster now as well, since there is no need for a translation layer anymore. I have updated a lot of the python dependencies as well, so testing it would be much more complicated, as you would need to create a new conda environment from the new environment file. First run a workflow using the current environment that you have, in the Then checkout to this PR branch, run the following commands in the CEA git repo folder: mamba env create -n cea-arm -f environment.yml
conda activate cea-arm
pip install -e . Run the same workflow using this new environment. Compare if the results are the same (especially for thermal network results) Let me know if you encounter any issues. Thanks! |
@reyery Thanks for the PR again. For Zurich-PR: Zurich-Master: |
Interestingly there are differences in the area of PV, but I don't think it is that significant. Would it be possible to try a larger scenario and see if affects more buildings. |
Hi @reyery |
Could potential fix #3120