Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: S3 spaces don't allow DIP Storage locations #1442

Closed
5 tasks
fitnycdigitalinitiatives opened this issue Apr 27, 2021 · 5 comments
Closed
5 tasks

Problem: S3 spaces don't allow DIP Storage locations #1442

fitnycdigitalinitiatives opened this issue Apr 27, 2021 · 5 comments
Labels
Status: review The issue's code has been merged and is ready for testing/review. Type: enhancement An improvement to existing functionality.
Milestone

Comments

@fitnycdigitalinitiatives

S3 Locations do not allow DIP Storage as a valid option. Will create pull request.


For Artefactual use:

Before you close this issue, you must check off the following:

  • All pull requests related to this issue are properly linked
  • All pull requests related to this issue have been merged
  • A testing plan for this issue has been implemented and passed (testing plan information should be included in the issue body or comments)
  • Documentation regarding this issue has been written and merged (if applicable)
  • Details about this issue have been added to the release notes (if applicable)
@sromkey
Copy link
Contributor

sromkey commented Apr 28, 2021

Thank you for contributing! I've asked @sevein to take a look at your PR.

@sevein sevein changed the title S3 Locations should allow DIP Storage Problem: S3 spaces don't allow DIP Storage locations May 4, 2021
@sevein sevein added this to the 1.13.0 milestone May 4, 2021
@sevein sevein self-assigned this May 4, 2021
@sevein
Copy link
Contributor

sevein commented May 4, 2021

artefactual/archivematica-storage-service#594 is merged, but I'll leave the issue "In progress" to remind us that we need to update the docs (this page - @fitnycdigitalinitiatives do you have time for this?) and possibly writing a new integration test since its environment has already MinIO set up.

@fitnycdigitalinitiatives
Copy link
Author

I just created a pull for the updated docs, but I'm a little unfamiliar with the integration test process. I imagine I could figure it out but more uncertain how soon I would be able to get to it.

@sevein
Copy link
Contributor

sevein commented May 4, 2021

No worries, we can do that some other time.

sevein pushed a commit to artefactual/archivematica-storage-service-docs that referenced this issue May 5, 2021
@sevein sevein added Status: review The issue's code has been merged and is ready for testing/review. and removed Status: in progress Issue that is currently being worked on. labels May 5, 2021
@sevein sevein removed their assignment May 5, 2021
@replaceafill replaceafill self-assigned this Jun 25, 2021
@replaceafill
Copy link
Member

I confirmed this works:

  • The DIP Storage option is now enabled in the Create Location form
    Captura de pantalla de 2021-06-25 07-32-22

  • The DIP was uploaded to AWS S3 after the transfer was done
    Captura de pantalla de 2021-06-25 07-36-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: review The issue's code has been merged and is ready for testing/review. Type: enhancement An improvement to existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants