Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing empty test directories #1652

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Removing empty test directories #1652

merged 1 commit into from
Nov 11, 2019

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Aug 20, 2019

These appear to be results of running rails new <app> and are not
used. The applications are tested via RSpec and their corresponding
spec directories.

In removing this, hopefully we reduce the chatter of a what appears to
be a very large code-base.

Related JIRA Ticket or GitHub Issue

See #1651

Motivation and Context

To reduce chatter of files and directories in the code-base.

Related JIRA Ticket or GitHub Issue

See #1651

How Has This Been Tested?

This has not been tested. However there are no references to "test_helper" in the code base.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

These appear to be results of running `rails new <app>` and are not
used. The applications are tested via RSpec and their corresponding
spec directories.

In removing this, hopefully we reduce the chatter of a what appears to
be a very large code-base.
@lmcglohon
Copy link
Contributor

@jeremyf Thanks for this. We are in the process of improving/refactoring our test infrastructure and this is one of the expected changes.

@lmcglohon lmcglohon self-assigned this Oct 15, 2019
@lmcglohon lmcglohon self-requested a review October 15, 2019 15:40
@lmcglohon lmcglohon merged commit 6c47bb9 into archivesspace:master Nov 11, 2019
@lmcglohon lmcglohon added this to the 2.8.0 milestone Nov 11, 2019
@lmcglohon lmcglohon modified the milestones: 2.8.0, 2.7.1 Feb 5, 2020
@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants