Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-975: Update to handle back button #1754

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

lorawoodford
Copy link
Contributor

The additional of the select_all checkbox in #1726 can potentially have the unintended consequence of reloading a search listing page with individual checkboxes selected but the select_all box unselected. This forces autocomplete to off for the multiselect column inputs for search listing results to avoid this behavior if the user uses the browser's back button.

Description

This PR sets autocomplete to off for the multiselect inputs. It also ensures that multiselection will work on agents by including the multiselect js in agents.browse_merge.js (since agents does not natively inclue search.js).

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/projects/ANW/issues/ANW-975

How Has This Been Tested?

Tested manually.

Screenshots (if appropriate):

Improper behavior prior to this PR.
out

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lmcglohon lmcglohon added this to the 2.8.0 milestone Jan 6, 2020
@lmcglohon lmcglohon merged commit 2f4b79b into archivesspace:master Jan 6, 2020
@lmcglohon lmcglohon modified the milestones: 2.8.0, 2.7.1 Feb 5, 2020
@lorawoodford lorawoodford deleted the ANW-975_contd branch February 17, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants