add proper i18n for titles of new records #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see how the test failure should be related to my changes but I'm not 100% sure. |
quoideneuf
previously approved these changes
Feb 1, 2022
quoideneuf
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splitting of i18n in action verb and object name singular caused wrong grammar on some languages with more morphologic grammar. This PR fixes that by reversing the splitting and introducing one translation string for each of the new object form titles.
Related JIRA Ticket or GitHub Issue
Fixes #2584
How Has This Been Tested?
visual testing
Screenshots (if appropriate):
Types of changes
Checklist: