Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to spreadsheet importer, RDE, and EAD exports #2747

Closed
wants to merge 6 commits into from

Conversation

jambun
Copy link
Contributor

@jambun jambun commented Jul 14, 2022

This pull request includes the following enhancements:

  • Select first cell when opening bulk import spreadsheet
  • Add support for restriction notes in RDE
  • Add local access restriction type to bulk import spreadsheet
  • Add note labels to bulk import spreadsheet
  • Include record uri as unitid in EAD export

These enhancements were funded by Princeton University and the National Library of Australia

@cdibella
Copy link
Contributor

@jambun Thanks so much for all this work and for submitting it as core code! We'll review it soon.

Note to code reviewers: this encompasses multiple JIRAs (including ANW 1489, ANW-1495, and ANW-1500) and the functionality is much desired by community members beyond those who funded the work.

@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Aug 10, 2022
@quoideneuf quoideneuf self-requested a review August 22, 2022 13:20
@quoideneuf quoideneuf self-assigned this Aug 22, 2022
quoideneuf pushed a commit to quoideneuf/archivesspace that referenced this pull request Aug 23, 2022
@quoideneuf quoideneuf closed this Aug 23, 2022
donaldjosephsmith pushed a commit that referenced this pull request Aug 29, 2022
* Support setting labels on all note types from the bulk importer

Adds a new 'l_' column to each note variant to let you set a label.

* ANW-1489 include the record URI as unitid[@type=aspace_uri] in EAD exports

* ANW-1495 Add local access restriction type column to bulk import spreadsheet

* Support restriction notes in RDE

* ANW-1489 add unit tests for EAD unitid[@type=aspace_uri]

* Update AO bulk import spreadsheet so first cell is selected

* test remediation for #2747

* upgrade backend rspec to 3.11 and set high limit for inspect output on failure objects

* ignore repository id when comparing repository-scoped uris in oai test results

Co-authored-by: Mark Triggs <mark@dishevelled.net>
Co-authored-by: Payten Giles <payten.giles@gmail.com>
Co-authored-by: James Bullen <jambun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants