Hudmol princeton cleanup #2782
Merged
Hudmol princeton cleanup #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new 'l_' column to each note variant to let you set a label.
…n failure objects
quoideneuf
force-pushed
the
hudmol-princeton-cleanup
branch
from
52c8340
to
cebf594
Compare
|
@donaldjosephsmith this all looked good to me, but I had to rework the tests and bit and post a new PR. |
donaldjosephsmith
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediates #2747
While doing this I noticed that the string returned by calling
:inspecton theMismatchErrorexception exceeded RSpec's default character limit, so I upgraded RSpec to 3.11, which allows for configuring the limit. I also noticed that the matcher will give false negatives for repository-scoped uris, since these will be arbitrary in a randomized test run; so I tweaked the matcher a bit to ignore repository id in uris.