Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release notes to release.yml workflow #2923

Conversation

quoideneuf
Copy link
Collaborator

@quoideneuf quoideneuf commented Feb 2, 2023

Update .github/workflows/release.yml so that release notes are build on GH.

Note: it's not possible to test this exactly as-is in another repo, because the secrets.GITHUB_TOKEN authentication key in any other repository will not be sufficient to bypass the rate-limited queries to the GitHub API for pull requests..

Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
My first time seeing Ruby keyword arguments

@brianzelip brianzelip merged commit 7aa7ce2 into archivesspace:master Feb 2, 2023
@quoideneuf quoideneuf deleted the adds-release-notes-to-gh-actions-release-workflow branch February 2, 2023 21:34
@cdibella cdibella added this to the 3.4.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants