-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANW-1477 allow users to recover / reset password #2979
ANW-1477 allow users to recover / reset password #2979
Conversation
d7b91f9
to
358a104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍🏻 I was a little surprised to see that it appears we never had fallbacks enabled for translations, so I'm glad you set that up. The only thing I'm wondering about is if a 5 minute expiration might be a little short for some setups with slow external email servers. I guess ideally we would make that a configuration option at some point.
Those suggestions all sound good. I also noticed the password form is not hiding the text as it should. |
d41ca55
to
c4c5014
Compare
c4c5014
to
3583d6b
Compare
@donaldjosephsmith I changed the time window from 5 to 30 minutes, and corrected the input field for the new password form. |
For local testing, recommend using https://www.npmjs.com/package/fake-smtp-server
I could not get the npm install working, so used docker:
with the following in
common/config.rb
: