ANW-1477 Password reset fixes/updates #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user_mailer uses standard ERB templates when composing emails. Being that the backend is a Sinatra app, it doesn't have Action View available for locating them. The method originally used to find them worked in the dev environment, but not in a release running on Jetty. This minimal change should append the correct view path in both cases. It will also only append the path once (in the initializer) instead of doing it every time send_reset_token is called.
brianzelip
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue and discussion on #2979
The view path setup for ActionMailer was not correct for release builds running on Jetty (via archivesspace.sh). This should take care of that. We now don't indicate to the user that an email address was not found for password reset, instead stating that if the account exists, and email will be sent. Also removes "recover" terminology in favor of "reset" for clarity/consistency.