Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Fix broken write_output method. #3 #4

Merged
merged 1 commit into from Apr 24, 2019

Conversation

greebie
Copy link
Contributor

@greebie greebie commented Apr 24, 2019

Fixes bug where write_output was broken. This occurred for two reasons:

  1. The local parameter filename was change in the call to stdout, but not changed in the function.
  2. The function referred to a no-longer-in-existence "output_write_file" function.

To test (without pypi test):

Fetch or clone repo.
cd au_notebook
pip uninstall au-notebook
python -m pip install ./

Launch notebook and test.
NOTE: The current output file request should say nb.write_output( etc.) now instead of just write_output( etc).

If for some reason, you already had the notebook running before you updated au_notebook, you will need to restart the notebook and import cells before the module will take effect.

@codecov-io
Copy link

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   30.87%   30.87%           
=======================================
  Files           2        2           
  Lines         149      149           
=======================================
  Hits           46       46           
  Misses        103      103
Impacted Files Coverage Δ
au_notebook.py 28.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0541d...7994408. Read the comment docs.

@greebie
Copy link
Contributor Author

greebie commented Apr 24, 2019

Ha! Codecov looks like a Game of Thrones wedding. :) I'll look into a few cycles for unit testing as a way to cap this project off.

@ruebot ruebot merged commit 22b519e into archivesunleashed:master Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants