Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Adds new FAQ question on "What if Cloud doesn't do X," Resolves #329 #330

Merged
merged 1 commit into from Oct 3, 2019

Conversation

ianmilligan1
Copy link
Member

GitHub issue(s):

If you are responding to an issue, please mention their numbers below.

What does this Pull Request do?

Adds a new question and answer in the "data analysis" section. See screenshot:

Screen Shot 2019-10-02 at 2 10 53 PM

How should this be tested?

Beyond usual tests, just reviewing the content.

Interested parties

@ruebot @SamFritz

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #330   +/-   ##
======================================
  Coverage    89.4%   89.4%           
======================================
  Files          35      35           
  Lines         623     623           
======================================
  Hits          557     557           
  Misses         66      66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ee8bb...cb5b90e. Read the comment docs.

@ianmilligan1
Copy link
Member Author

Thanks @ruebot – I'll let you review at your convenience @SamFritz and if it looks good feel free to Squash and Merge. Safe travels today!

Copy link
Member

@SamFritz SamFritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this in @ianmilligan1 - very useful as use cases increase

@ruebot ruebot merged commit 9e76176 into master Oct 3, 2019
@ruebot ruebot deleted the issue-329 branch October 3, 2019 19:38
@ruebot
Copy link
Member

ruebot commented Oct 3, 2019

deployed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants