This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Setup ESlint for project; resolves #89. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ESlint config - Update gitignore - Update TravisCI config - Add Rake task - Clean-up JS files - Ignore some JS files
|
Oh yeah, TravisCI runs the ESlinting now too, so that should be good too. |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 26 26
Lines 239 239
=======================================
Hits 208 208
Misses 31 31Continue to review full report at Codecov.
|
ianmilligan1
previously approved these changes
Apr 9, 2018
ruebot
changed the title
greebie
reviewed
Apr 9, 2018
| { | ||
| "extends": "airbnb-base/legacy", | ||
| "globals": { | ||
| "jQuery": true, |
|
lgtm. Only comment is the optional add of |
ianmilligan1
approved these changes
Apr 9, 2018
greebie
approved these changes
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested locally by moving the
gexffile, and also removing all the nodes and edges to simulate an empty graph so recreate the two conditionals. Everything looks fine, but just want to make sure things are good not on my laptop.@greebie and @ianmilligan1 would you mind doing a smoke test on your end?