Enable pyspark console in docker container #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove alpine/apk dependencies at the end of the build to reduce image size. README: describe how to start pyspark console inside Docker container.
ruebot
reviewed
Feb 24, 2020
| git \ | ||
| wget | ||
| wget \ | ||
| && apk add --update python |
There was a problem hiding this comment.
Any reason this line can't just be python?
There was a problem hiding this comment.
Both git and wget are installed into the virtual package build-dependencies, which gets deleted at the end of the build. To keep python out of this package, a separate add without --virtual is required.
Actually, --update is not required again here.
There was a problem hiding this comment.
(2/2) Installing python2 (2.7.16-r2)
We should go with Python 3 here. Any reason we're using Python 2?
|
I tried python 3 first but pyspark (?) requires version 2. I also found
that strange, but didn't investigate further.
…On Tue, Feb 25, 2020, 13:35 Nick Ruest ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Dockerfile
<#20 (comment)>
:
> git \
- wget
+ wget \
+ && apk add --update python
(2/2) Installing python2 (2.7.16-r2)
We should go with Python 3 here. Any reason we're using Python 2?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20?email_source=notifications&email_token=AAADUQZ2RDUZNYJABC7OUWDREUGAVA5CNFSM4K2LNI4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWZ5DGA#discussion_r383851252>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUQ7O2QLJ5RUKQ5LQ543REUGAVANCNFSM4K2LNI4A>
.
|
|
@sepastian I don't believe so. I use Python 3.7.3 locally with PySpark, and |
|
Ok, will take another look and update the PR, python 3 should be used.
…On Tue, Feb 25, 2020, 13:48 Nick Ruest ***@***.***> wrote:
@sepastian <https://github.com/sepastian> I don't believe so. I use
Python 3.7.3 locally with PySpark, and aut.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20?email_source=notifications&email_token=AAADUQZO327U4BA2WRYZTV3REUHR7A5CNFSM4K2LNI4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM32PNQ#issuecomment-590849974>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUQ7XXUIX2JOVRNGHESTREUHR7ANCNFSM4K2LNI4A>
.
|
|
Closing this and creating a new PR against current docker-aut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
Dockerfile