This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Truncate fields on search results display? #9
Labels
Comments
That'd be perfect, I think. |
@ianmilligan1 since this is just on the results view, do we need to worry about expanding the ellipsis? If not, I have a PR almost ready to go. |
Yep that’s perfect. And is ‘this page links to’ presented in descending order of frequency? |
No. It's just the first 5 in the array on the search results view. The item's view lists everything. |
Ok good to know (be good for documentation down the road). This all looks great to me, I’d say we are ready for a PR and to close this one! |
Cool. Just finishing the test, and we should be good to go. |
ruebot
added a commit
that referenced
this issue
Oct 11, 2017
* Truncate fields that are arrays over 5 items; * Add test for helper method; * Use helper method on links_domains for search results.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now each record displays title, host, crawl date, content type, domain, this page links to, institution, collection name, and collection number. All but 'this page links to' or perhaps 'title' have natural limits.
In this case, a page is linking to dozens of other domains:
![screen shot 2017-08-17 at 3 03 02 pm](https://user-images.githubusercontent.com/3834704/29429095-69cd0446-835d-11e7-9090-1fbad1d8f0eb.png)
Should we have a limit – i.e. list the top 10, to keep from cluttering up the results page too much?
The text was updated successfully, but these errors were encountered: