Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inherited templates should not replace keys #20

Closed
Torxed opened this issue Sep 26, 2019 · 2 comments
Closed

inherited templates should not replace keys #20

Torxed opened this issue Sep 26, 2019 · 2 comments
Labels
feature New feature or request

Comments

@Torxed
Copy link
Member

Torxed commented Sep 26, 2019

If two templates have the same "step name" or key, the inherited template should not replace the step of the current template.

"ubuntu" inherits "workstation"
"ubuntu" should replace whatever "desktop"-environment step "workstation" has for isntance. And not the other way around(?).
@Torxed Torxed added feature New feature or request question labels Sep 26, 2019
@Torxed
Copy link
Member Author

Torxed commented Nov 27, 2019

Make it a flag in args which direction it should happen?

Torxed added a commit that referenced this issue Nov 29, 2019
@Torxed
One step in fixing #20. User-given parameters override template. And …
56ad7ef 
…next is reworking the inheritance structure of the templates
@Torxed
Copy link
Member Author

Torxed commented Aug 20, 2020

Closing this issue since we've moved away from .json files and dropped the support entirely for .py files, which doesn't require nested reading before beginning installation. They can simply chain-call each other one by one without prior knowledge of each other.

@Torxed Torxed closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Torxed