Rework user management

[svartkanin]

Re-worked user management

Fixes

• Generated user_*.json files do not appear to store all answers #1112
• Renaming config files result in 2 configs missing warning #1183
• Creating user and promoting him does not show in the script #1182
• Prompt for creating a user with sudo privileges is unclear as to whether it's a question or a request for a user name/login. #1109

Changes

New file format for user credentials

The format for the credentials config file has changed to allow specifying multiple users. This change is backwards compatible, so if old configurations get passed they are parseable and will internally be transformed into the new format. When saving configurations they will be saved in the new format.

Old format

{
	"!root-password": "<root password>",
	"!users": {
		"username": {"!password": "<user password>"}
	},
	"!superusers": {
		"admin": {"!password": "<admin password>"}
	}
}

New format

{
	"!root-password": "<root password>",
	"!users": [
		{
			"username": "<USERNAME>",
			"!password": "<PASSWORD>",
			"sudo": false
		},
		{
			"username": "<SUDO_USERNAME>",
			"!password": "<PASSWORD>",
			"sudo": true
		}
	]
}

User object

!superuser does not exist anymore, instead only the internal !users is handled whereas the entries are now a User class object

@dataclass
class User:
	username: str
	password: str
	sudo: bool

This greatly simplified the code in some parts and makes it easier to avoid bugs :)

Update to menu

The menu has now only 1 entry to define users in which the sudo privileges can be specified.

@Torxed I'll let you know when it's ready, probably tomorrow :)

[dylanmtaylor]

Can you also update the docs and schema for this change?

[svartkanin]

Yep will do that too :)

[Torxed]

I don't know why i did'nt do this right away haha, way more clean! Thank you!

[dylanmtaylor]

May I suggest we don't merge this until 2.5.0 since it's a schema-breaking change?

[svartkanin]

It's not a breaking change since it's backwards compatible :)

I think the current state is way more fragile since we only support a single user in a file. Which means - and has been pointed out in the issues - that users will lose their actual settings if they try to export them.

In addition I think the 1 different settings of "users" and "superusers" seemed to have stirred quite some confusion which this resolves as well

[Torxed]

Yea it appears backwards compatible, I get that there's still some work left.
But I'd be happy to run tests on this on the backwards compatibility side and if they're successful I'd be happy to merge this in time for the release :)

[dylanmtaylor]

Yea it appears backwards compatible, I get that there's still some work left. But I'd be happy to run tests on this on the backwards compatibility side and if they're successful I'd be happy to merge this in time for the release :)

I like this plan. I was under the impression that this was a breaking change

[svartkanin]

@Torxed This should be ready for a review now :)

[Torxed]

@Torxed This should be ready for a review now :)

Testing commences now! :D

[Torxed]

It loads the old format where I created a !superuser and a !user.

It also installs with the old configuration:

And no shocker i guess, but the permissions are set correctly to:

[Torxed]

Great work, especially making it backwards compatible. Merged and done! :)

[svartkanin]

Fantastic, thanks for double checking everything :)

[svartkanin]

I think the related issues where not closed automatically

[Torxed]

You are correct heh, gotta love Github.

[svartkanin]

I'm not sure what triggers it, maybe only mentioning it in the title 🤷‍♂️

[Torxed]

It's if the word fix is in the same sentence as the issue link I think.
There are some other aliases for it, but it has to be in the same sentence i recon.
But I don't mind closing the manually too hehe, gives me a sense of purpose 👼

[erikdubois]

Could you add a text when we can start testing it?

[svartkanin]

It is in master now so basically from there now :), @Torxed will this make it into the new iso?

[Torxed]

It is in master now so basically from there now :), @Torxed will this make it into the new iso?

It will :) I'm planning on running several tests throughout the day.
If they all succeed, I'm aiming to release the next version later this evening or very early tomorrow :)