Added a advanced=bool flag to Profile() class and enabled it on the cosmic-epoch profile #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tain profiles behind --advanced
svartkanin
reviewed
Aug 21, 2024
svartkanin
reviewed
Aug 21, 2024
… --advanced checks on Profile()
… sys.argv for cosmic-greeter check
|
Should be good to go now, tested and verified that greeter isn't visible in other DE's and the desktop profile itself isn't visible either without |
svartkanin
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be able to hide certain profiles behind
--advanced.We also enabled it on the
cosmic-epochdue to it being pre-release alpha still with a note on the upstream repo:This complements issue: #2358 and thus #2615