Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the warning about missing modules.builtin.modinfo #109

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix the warning about missing modules.builtin.modinfo #109

merged 1 commit into from
Jul 5, 2022

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Jul 3, 2022

depmod: WARNING: could not open modules.builtin.modinfo at /tmp/mkinitcpio.EftMSK/root/lib/modules/5.15.52-1-lts: No such file or directory

kmod wants modules.builtin.modinfo since v30 [1]

[1] https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/commit/?id=0246e06340df292b5dda4bc00e24cc9ae894e881

@heftig
Copy link
Member

heftig commented Jul 4, 2022

While you're at it, you should also add modules.order so we have the complete set, though it's not strictly required.

install -m644 -t "$moduledest" "$_d_kmoduledir"/modules.{builtin,builtin.modinfo,order}

> depmod: WARNING: could not open modules.builtin.modinfo at /tmp/mkinitcpio.EftMSK/root/lib/modules/5.15.52-1-lts: No such file or directory

kmod wants modules.builtin.modinfo since v30 [1].

Also adds modules.order as suggested by heftig. That file is used (if
exists) since the first commit of depmod.

[1] https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/commit/?id=0246e06340df292b5dda4bc00e24cc9ae894e881
@yan12125
Copy link
Contributor Author

yan12125 commented Jul 4, 2022

Thanks! Updated.

@grazzolini
Copy link
Member

@heftig any documentation on why we need modules.order? This PR looks fine to me otherwise, and I think I should probably patch this on mkinitcpio.

@grazzolini grazzolini merged commit 84a00b5 into archlinux:master Jul 5, 2022
@yan12125 yan12125 deleted the depmod-need-modinfo branch July 5, 2022 14:36
@yan12125
Copy link
Contributor Author

yan12125 commented Jul 5, 2022

Probably related to this - modprobe uses modules.dep.bin generated by depmod.

modules.order
--------------------------------------------------
This file records the order in which modules appear in Makefiles. This
is used by modprobe to deterministically resolve aliases that match
multiple modules.

(https://www.kernel.org/doc/Documentation/kbuild/kbuild.txt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants