Fix .env loading in development #799
Conversation
`Dotenv::create($paths)` was the syntax for releases before v4
Do they support older Laravel? The dev dependencies are used in the CI build with different Laravel versions |
|
Right, I see now that it's actually already a dependency of |
|
Ah yeah, it's a dependency of laravel/framework, you can remove it. I think I added it before we had full laravel/framework in the dev dependencies. But it might not be needed now |
erikgaal
changed the title
Codecov Report
@@ Coverage Diff @@
## 3.x #799 +/- ##
=========================================
Coverage 87.32% 87.32%
Complexity 383 383
=========================================
Files 103 103
Lines 1128 1128
=========================================
Hits 985 985
Misses 143 143 Continue to review full report at Codecov.
|
|
Thanks Erik! Is this change just a codebase cleanup, or were you contributing it because there was some issue with the package? Asking so that I know if you need this released now |
|
It's just a cleanup in preparation of a L9 compatibility PR I was planning to submit. |
* Upgrade vlucas/phpdotenv to ^5.0 `Dotenv::create($paths)` was the syntax for releases before v4 * Remove vlucas/phpdotenv dependency and make it work with newer versions.
Dotenv::create($paths)was the syntax for releases before v4. As it's a dev dependency, I think it's reasonable to require the latest major version at minimum.