L10 compatibility #12
Conversation
| include: | ||
| - laravel: "^9.0" | ||
| testbench: "^7.0" | ||
| - laravel: "^10.0" | ||
| testbench: "^8.0" | ||
| exclude: | ||
| - laravel: "^10.0" | ||
| php: "8.0" |
There was a problem hiding this comment.
Why does include have testbench and exclude has php? Where is testbench used?
There was a problem hiding this comment.
Also, at this point it might be better to just use something like:
- laravel: 9
php: 8.0
- laravel: 10
php: 8.1That way the code will run on both PHP versions and both Laravel versions, we don't really care about L9 + 8.0 I think. And the syntax will be much simpler than having PHP versions listed, Laravel versions listed, an include section, and an exclude section.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Supports Laravel 6, 7, 8, and 9. | |||
| Supports Laravel 6, 7, 8, 9, and 10. | |||
There was a problem hiding this comment.
| Supports Laravel 6, 7, 8, 9, and 10. | |
| Supports Laravel 9 and 10. |
|
|
||
| - name: Install dependencies | ||
| run: composer require "laravel/framework:^${{matrix.laravel}}.0" | ||
| run: composer require "laravel/framework:${{matrix.laravel}}" |
There was a problem hiding this comment.
I'd keep the original syntax, the workflow name is more readable then (L10 instead of L^10). With Laravel we don't care about specifying the minor version, so there's no need to specify versions as ^x in the matrix.
Edit: Seems like we were using a different pattern in the tenancy repo, I'll see if it's worth changing.
|
I'll close this PR in favor of the other one here that we finished today. For the preferred workflow syntax, see this and my reviews above: https://github.com/archtechx/virtualcolumn/pull/11/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f If you could make those changes in your other PRs, I can merge them today and hopefully tag a tenancy release. |
* Add L10 support * Update PHP version in ci.yml * Update ci.yml * Revert ci.yml changes * Migrate PHPUnit XML config using "--migrate-configuration" * Update phpunit.xml (delete cacheDirectory, use backupStaticAttributes instead of backupStaticProperties) * Delete backupStaticAttributes * Add PHP version matrix * Use ci.yml from #12 * Correct Laravel matrix versions * Revert ci.yml changes * Use multiple PHP versions * Update ci.yml * Don't use PHP 8 with Laravel 10 in CI * Update ci.yml * Remove L6 and L8 support * Use single PHP version in CI * Update ci.yml * Change matrix in ci.yml * swap laravel 9 & 10 * Update README.md --------- Co-authored-by: Samuel Štancl <samuel@archte.ch>
Hi!
This PR adds L10 compatibility for Tenancy to work.
Related archtechx/tenancy#1065