refactor(arch3-core)!: rewrite all queries in the ArchwayClient #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lint jsdoc - import sorting rules - enforce single quotes - parallelize the linting tasks to reduce the execution time
The queries did not conform to the `CosmWasmClient` API. It used static method and it exposed unnecessary internal interfaces from the `@archwayhq/arch3-proto` package. This refactor simplifies the API usage and isolates the querying interface to a separate module.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @returns An offline `SigningArchwayClient`. | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/require-await | ||
| public static override async offline( |
Check failure
Code scanning / ESLint
Disallow async functions which have no `await` expression
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The queries did not conform to the
CosmWasmClientAPI. It used static methods and exposed unnecessary internal interfaces from the@archwayhq/arch3-protopackage.This refactor simplifies the API usage and isolates the querying interface to a separate module.
Some linting rules also changed: