Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not embed keeper interface into keeper struct #169

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

ParthDesai
Copy link
Contributor

@ParthDesai ParthDesai commented May 31, 2022

  • Embedding keeper interface into struct cause interface to be unenforceable at compile time which results in runtime error

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #169 (00f11aa) into main (f435855) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   56.37%   56.37%           
=======================================
  Files          15       15           
  Lines        1247     1247           
=======================================
  Hits          703      703           
  Misses        496      496           
  Partials       48       48           
Impacted Files Coverage Δ
x/gastracker/keeper/keeper.go 69.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f435855...00f11aa. Read the comment docs.

@ParthDesai ParthDesai merged commit e15b6f5 into main May 31, 2022
@ParthDesai ParthDesai deleted the fix-keeper-struct branch May 31, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant