-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/callback): throw events #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/callback-module #520 +/- ##
=======================================================
Coverage ? 63.85%
=======================================================
Files ? 70
Lines ? 4111
Branches ? 0
=======================================================
Hits ? 2625
Misses ? 1357
Partials ? 129 ☔ View full report in Codecov by Sentry. |
fdymylja
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
spoo-bar
added a commit
that referenced
this pull request
Jan 9, 2024
* feat: adding x/callback module proto files (#480) * adding proto for callback * generating proto types * feat(x/callback): Adding module skeleton (#495) * adding callback module skeleton * lint fix * feat(x/callback): Implement the storage and validation of params (#498) * adding params types * adding params test * adding param keeper get and set * fix lint * refactor: using collections for params (#503) using collections for params * feat(x/callback): Implement the storage of callback (#500) * adding callback state keepers * updating block height stuff to use int64 instead of uint64 * cleanup * adding type validation * using collections * fixing the collection stuff * storing collection schema in keeper --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> * feat(x/callback): Implementing Query Server (#509) * params() * callbacks() * using dec coin instead of coin * estimateCallbackFees() * linting * refactor the estimate fees endpoint * linting * adding review comments * feat(x/callback): Implementing Msg Server (#513) * adding update params * request callback * merge updates * fixing callback proto * using only native denom for stuff * handling fees when requesting callback * linting * custom error * addressing pr review comments * do auth stuff before token transfer --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> * feat(x/callback): Implement the callback execution (#508) * executing callbacks in endblocker * adding docs * cleanup * pleasing the linter gods * adding test for callbackmsg string marshal * linter. i hate you * addressing pr review comments * addressing pr review comments * feat: Implementing query and tx CLI (#516) * adding cli query params * adding cli query estimate-callback-fees & callbacks * implementing sdk.Msg interface * adding cli tx request-callback & cancel-callback * lint fixes * feat: Implement genesis methods (#515) * removing callbacks from genesis state * implementing base genesis * implement init and export genesis * exporting callbacks in genesis * exporting callbacks in genesis * linting * feat(x/callback): Handle fees (#518) * adding helper methods for x/bank * returning fees in cancel callback * handling fees post callback execution * pr review comments addressing * feat(x/callback): throw events (#520) * creating event types * adding event emit helpers * emitting events * fixing merge --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> * feat(x/callback): do app wiring (#519) * implementing callback module app wiring * adding to upgrade handler * linting * registering msg codecs * test: Adding x/callback tests (#524) * adding callback types test * adding genesis types test * adding SaveCallback tests * adding DeleteCallback tests * adding RequestCallback tests * adding CancelCallback tests * linting * fixing issue when could not save callbacks * adding callback-test * adding tests for abci * adding TestGetCallbacksByHeight * adding TestGetAllCallbacks * adding TestIterateCallbacksByHeight * adding TestCallbacks * implementing TestEstimateCallbackFees * fixing issue with out of gas error txfee refund handling * fixing linting * cleanup * cleanup the test contract * fixing issue with callback params not being considered * linting 😶🌫️ * docs(x/callback): adding module specs (#526) * Create LICENSE * adding spec boilerplate * Update README.md * Update 01_state.md * Update 02_messages.md * Update 03_end_block.md * Update 04_events.md * Update 06_wasm_bindings.md * Update 05_client.md * typo fixes * Update CHANGELOG.md * changing the typed event for callback success and failure * updating swagger file * pr review addressing --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw events on