Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): fix fade-modal transition effect works on enter state #3007

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Feb 29, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

modal 组件在默认的 fade-modal 遮罩层动画下,淡入渐进效果不生效。在 #3000 提出该问题但非 v-if / v-show 逻辑导致。

iShot_2024-02-29_14.11.42.mp4

image

image

Solution

修正拼写错误导致动画缺失
修复效果:

iShot_2024-02-29_14.17.35.mp4

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
modal 修复遮罩层 fade-modal 过渡动画在进入时不生效问题 fix fade-modal transition effect works on enter state Closes #3000, Closes #2836

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Feb 29, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@flsion flsion added the type: 🔮 style Something about component style label Mar 1, 2024
@flsion flsion added this to the 2.54.6 milestone Mar 1, 2024
@flsion flsion merged commit 64cafb4 into arco-design:main Mar 1, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 🔮 style Something about component style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal mask lose the transition fade effect Modal组件中的fade动画无法作用
2 participants