Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Google Lighthouse score #41

Closed
4 tasks done
tomchen opened this issue Sep 10, 2021 · 1 comment
Closed
4 tasks done

Improve Google Lighthouse score #41

tomchen opened this issue Sep 10, 2021 · 1 comment
Labels
a11y Accessibility enhancement Improvement medium priority Medium priority

Comments

@tomchen
Copy link
Member

tomchen commented Sep 10, 2021 •
edited
Loading

Will do / have done:

  • Serve images in next-gen formats (.webp)
  • Buttons do not have an accessible name
  • [user-scalable="no"] is used in the element or the [maximum-scale] attribute is less than 5
  • Ensure text remains visible during webfont load (by using font-display: swap;)

Won't/can't do:

  • Serve static assets with an efficient cache policy (long cache lifetime) [idem]
  • Avoid enormous network payloads [already minified]
  • Some elements have a [tabindex] value greater than 0 [by design]
@tomchen tomchen added enhancement Improvement low priority Low priority a11y Accessibility labels Sep 10, 2021
tomchen added a commit that referenced this issue Sep 10, 2021
@tomchen
fix: aria-hidden for disabled buttons (#41);
4d4caec 
allow user-scale (#41)
tomchen added a commit that referenced this issue Sep 11, 2021
@tomchen
feat: change png/jpg to lossless webp (#41)
19a9ec3
@tomchen
Copy link
Member Author

tomchen commented Sep 11, 2021

Desktop:

arcomage_lighthouse_score_20210911

@tomchen tomchen closed this as completed Sep 11, 2021
tomchen added a commit that referenced this issue Sep 13, 2021
@tomchen
fix: font-display: swap (#41)
893b117
@tomchen tomchen mentioned this issue Sep 13, 2021
Closed
@tomchen tomchen added medium priority Medium priority and removed low priority Low priority labels Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Accessibility enhancement Improvement medium priority Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomchen