This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
Provide capability to push raw events #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
Interpretation of EventType & DataVersion are not working as it should, will fix it and provide tests |
|
This is done but I've created #66 as this is not ideal. Feel free to let me know what you think @SamVanhoutte & @stijnmoreels |
|
Sorry @tomkerkhove for the review delay. It's almost February! 😊 |
|
Not sure if I'm following, what does February have to do with that? :) |
|
Given I need this for arcus-azure/arcus.eventgrid.proxy#29 and it works + nothing breaking I'll merge this in but feel free to do review this and I'll do a follow-up PR |
tomkerkhove
added a commit
to arcus-azure/arcus.eventgrid.proxy
that referenced
this pull request
Jan 28, 2019
- Provide capability to push events to Azure Event Grid via API - Provide unit tests - Provide integration tests - Validation for configuration Relates to #24 and running integration tests in CI will be done via #28 . This PR depends on arcus-azure/arcus.eventgrid#65 as it's now using the preview package on MyGet and should be the official one instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide capability to push raw events.
Closes #57