Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LangVersion. Consolidate styling and conventions. #345

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

fiseni
Copy link
Collaborator

@fiseni fiseni commented Jul 21, 2023

Closes #342, Closes #343. This was a tedious job, but it had to be done.

  • Updated C# version to 11.
  • Consolidated project files (.csproj)
  • Consolidated test project files and updated report generation.
  • Updated pipelines - use NET 7 SDK (we need it for C#11), fix docker files, etc.
  • Updated .editorconfig and applied the styling.
  • Manually updated all inconsistencies (the usage of this and all other details).
  • Added config to ignore some warnings related to missing XML comments (it was polluting the output, and we were missing more important stuff). Ignored the following warning:
    • 1591 Missing XML comment for publicly visible type or member 'Type_or_Member'
    • 1573 Parameter 'parameter' has no matching param tag in the XML comment for 'parameter'
    • 1712 Type parameter 'type parameter' has no matching typeparam tag in the XML comment on 'type'
  • Other fixes and cleanup.

Note: @ardalis the 2-space indent is making the code hard to read (e.g. check this file). I do understand that you like that style, but if you change your mind let me know :)

@fiseni fiseni requested a review from ardalis July 21, 2023 12:07
@fiseni
Copy link
Collaborator Author

fiseni commented Jul 21, 2023

Hide whitespaces while reviewing, otherwise it's overwhelming.
image

@ardalis ardalis merged commit c8c5a87 into main Jul 21, 2023
2 checks passed
@ardalis
Copy link
Owner

ardalis commented Jul 21, 2023

This was... big. :)

@fiseni fiseni deleted the fiseni/langversion-conventions branch July 24, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update conventions and styling Update LangVersion to C# 10 or 11
2 participants