Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-method fields in Path Object Item #4934

Merged
merged 4 commits into from Mar 31, 2023

Conversation

hunterpetersen
Copy link
Contributor

馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4933

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested schema generation locally and in Docker.

Test Environment:

  • OS: macOS Monterey 12.6.1
  • @graphql-mesh/openapi:
  • NodeJS: 14.19.0

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

馃 Changeset detected

Latest commit: 0a75faf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@omnigraph/openapi Patch
@graphql-mesh/openapi Patch
nextjs-apollo-example Patch
nextjs-sdk-example Patch
javascript-wiki Patch
typescript-location-weather-example Patch
openapi-meilisearch Patch
openapi-stackexchange Patch
openapi-stripe Patch
openapi-subscriptions Patch
openapi-youtrack Patch
programmatic-batching-example Patch
gateway-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan
Copy link
Owner

ardatan commented Jan 1, 2023

Thank you for the PR @hunterpetersen !
Could you add some tests to prevent future regressions? And could you also create a changeset using yarn changeset so we can bump the version?

@ardatan ardatan merged commit cc754db into ardatan:master Mar 31, 2023
12 checks passed
@theguild-bot theguild-bot mentioned this pull request Apr 24, 2023
This was referenced Apr 30, 2024
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path object param check fails in OpenAPI spec
2 participants