mergeTypeDefs overwrite existing fields

[simplecommerce]

Hi,

I was wondering if it was possible to use mergeTypeDefs to overwrite existing field definitions.

For example:

console.log(print(mergeTypeDefs([
  gql`
type MyType {
  _id: ID!
}  
  `,
  gql`
type MyType {
  _id: ID
}  
  `,
])));

I would expect it to return

type MyType {
  _id: ID
}  

Is there a way to achieve this?
I know we can append fields to types or inputs but I can't seem to see how this can be achieved, even if I look at the options.

I think I am looking for something similar to this: #2051

Any help is appreciated, thanks.

[ardatan]

Hi @simplecommerce !
mergeTypeDefs isn't intended to overwrite field types like this. I cannot guarantee it works like you expected. Maybe you can create a failing test in a draft PR and we can work together on it.

[simplecommerce]

Thanks for the reply, I have added the test cases to the best of my knowledge here: #5075

I assume a change or feature like this would require an option to be passed in order to not cause a breaking change in the existing behavior.

My use case is specific, I have a core system that has predefined schemas and resolvers.
I use mergeTypeDefs to allow extending existing core schemas, but I would also like to be able to override the fields to change them from required to not required or maybe even the types.

I know I can technically just create a new query or mutation but this would be more work just to remove a required field.

Thanks!

[simplecommerce]

@ardatan I was just curious, why was this feature cancelled or closed? #2065

From what I saw in the discussion related to it, it seems to allow me to do what I would need.

[ardatan]

It is not cancelled. I just didn't have enough time to tackle that feature. PRs are welcome if anyone is interested in.

[simplecommerce]

It is not cancelled. I just didn't have enough time to tackle that feature. PRs are welcome if anyone is interested in.

I took your previous code and implemented it in my PR here: #5075

I also took your test cases and added the ones from this message: #2051 (comment)

It is my first time creating a PR so I hope everything is ok.