New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate Request and ExecutionParams types #3180
Conversation
🦋 Changeset detectedLatest commit: 3931762 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as alpha in npm (based on the declared
|
31ed61a
to
6be53eb
Compare
- also affixes rootValue to Request - when delegating with delegateToSchema, rootValue can be set multiple ways: * when using a custom executor, the custom executor can utilize a rootValue in whichever custom way it specifies. * when using the default executor (execute/subscribe from graphql-js): -- rootValue can be passed to delegateToSchema via a named option -- rootValue can be included within a subschemaConfig -- otherwise, rootValue is inferred from the originating schema - when using wrapSchema/stitchSchemas, a subschemaConfig can specify the createProxyingResolver function which can pass whatever rootValue it wants to delegateToSchema as above.
3dc3476
to
3931762
Compare
Reference:
|
I think our Request type can have context/info in it, optional properties that make sense only when the request originates from within execution of a parent GraphQL Request. It probably makes sense to eventually put these within the extensions map, but I think this is fine for now. Thoughts? |
rootValue in whichever custom way it specifies.
-- rootValue can be passed to delegateToSchema via a named option
-- rootValue can be included within a subschemaConfig
-- otherwise, rootValue is inferred from the originating schema
createProxyingResolver function which can pass whatever rootValue it
wants to delegateToSchema as above.