Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pin babel deps to exact version #4118

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

dobesv
Copy link
Contributor

@dobesv dobesv commented Jan 12, 2022

Only devDependencies should be pinned for libraries.

Description

Related #4107

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Only devDependencies should be pinned for libraries.
@vercel
Copy link

vercel bot commented Jan 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-tools/BdRccmq2MpZw9UmLq2zpxVLvTDZT
✅ Preview: https://graphql-tools-git-fork-dobesv-pluck-deps-use-range-theguild.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2022

🦋 Changeset detected

Latest commit: 231687a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/graphql-tag-pluck Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +39 to +41
"@babel/parser": "7.16.8",
"@babel/traverse": "7.16.8",
"@babel/types": "7.16.8",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can emove the dev dependencies here as they are redundant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if this ran the test suite or transpiled itself, the versions could be pinned exactly.

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dobesv Thank you so much for this, can you please also add a patch changeset as described by #4118 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants