-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pin babel deps to exact version #4118
Conversation
Only devDependencies should be pinned for libraries.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/graphql-tools/BdRccmq2MpZw9UmLq2zpxVLvTDZT |
🦋 Changeset detectedLatest commit: 231687a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"@babel/parser": "7.16.8", | ||
"@babel/traverse": "7.16.8", | ||
"@babel/types": "7.16.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can emove the dev dependencies here as they are redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking if this ran the test suite or transpiled itself, the versions could be pinned exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dobesv Thank you so much for this, can you please also add a patch changeset as described by #4118 (comment) ?
Only devDependencies should be pinned for libraries.
Description
Related #4107
Type of change
Please delete options that are not relevant.