-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test with nested interfaces #6206
Conversation
This file contains the failing test merging nested interfaces
|
You don't have the merging configurations for |
Merged types includes more types than merge types defined:
Merge types are User and TransactionDecorator but Transaction, CardTransaction and SEPACreditTransferTransaction were listed, not sure why. |
}, | ||
CardTransaction: { | ||
decorators: (_, { ids }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong because decorators
don't have an argument called ids
but it needs id
from the parent id
Transaction: { | ||
decorators: (_, { ids }) => { | ||
decorators: ({ id }: { id: string }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong because there is no argument ids
but it needs id
from Transaction
to fetch decorators
This file contains the failing test merging nested interfaces
馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
When having nested interfaces the merge does not find/call the resolver
Related # 6204
Type of change
Please delete options that are not relevant.
Failing test
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Run tests.
Test Environment:
@graphql-tools/...
:Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...