Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test with nested interfaces #6206

Closed
wants to merge 3 commits into from

Conversation

xharkonen
Copy link

@xharkonen xharkonen commented May 22, 2024

This file contains the failing test merging nested interfaces

馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

When having nested interfaces the merge does not find/call the resolver

Related # 6204

Type of change

Please delete options that are not relevant.

Failing test

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Run tests.

Test Environment:

  • OS:
  • @graphql-tools/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

This file contains the failing test merging nested interfaces
Copy link

changeset-bot bot commented May 22, 2024

鈿狅笍 No Changeset found

Latest commit: 68048c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan
Copy link
Owner

ardatan commented May 22, 2024

You don't have the merging configurations for Transaction types. So it doesn't know how to resolve decorators field from the other subchema that has decorators in it.

@xharkonen
Copy link
Author

Merged types includes more types than merge types defined:

    mergedTypes [Object: null prototype] {
      Query: {
        typeName: 'Query',
        targetSubschemas: Map(0) {},
        typeMaps: Map(2) {
          [Subschema] => [Object: null prototype],
          [Subschema] => [Object: null prototype]
        },
        selectionSets: Map(0) {},
        fieldSelectionSets: Map(0) {},
        uniqueFields: {},
        nonUniqueFields: {},
        resolvers: Map(0) {},
        delegationPlanBuilder: [Function: memoized]
      },
      TransactionDecorator: {
        typeName: 'TransactionDecorator',
        targetSubschemas: Map(1) { [Subschema] => [Array] },
        typeMaps: Map(2) {
          [Subschema] => [Object: null prototype],
          [Subschema] => [Object: null prototype]
        },
        selectionSets: Map(1) { [Subschema] => [Object] },
        fieldSelectionSets: Map(0) {},
        uniqueFields: { decorationKey: [Subschema], decorationType: [Subschema] },
        nonUniqueFields: {},
        resolvers: Map(1) {
          [Subschema] => [Function: batchMergedTypeResolverWrapper]
        },
        delegationPlanBuilder: [Function: memoized]
      },
      Transaction: {
        typeName: 'Transaction',
        targetSubschemas: Map(0) {},
        typeMaps: Map(2) {
          [Subschema] => [Object: null prototype],
          [Subschema] => [Object: null prototype]
        },
        selectionSets: Map(0) {},
        fieldSelectionSets: Map(0) {},
        uniqueFields: {},
        nonUniqueFields: {},
        resolvers: Map(0) {},
        delegationPlanBuilder: [Function: memoized]
      },
      CardTransaction: {
        typeName: 'CardTransaction',
        targetSubschemas: Map(0) {},
        typeMaps: Map(2) {
          [Subschema] => [Object: null prototype],
          [Subschema] => [Object: null prototype]
        },
        selectionSets: Map(0) {},
        fieldSelectionSets: Map(0) {},
        uniqueFields: {},
        nonUniqueFields: {},
        resolvers: Map(0) {},
        delegationPlanBuilder: [Function: memoized]
      },
      SEPACreditTransferTransaction: {
        typeName: 'SEPACreditTransferTransaction',
        targetSubschemas: Map(0) {},
        typeMaps: Map(2) {
          [Subschema] => [Object: null prototype],
          [Subschema] => [Object: null prototype]
        },
        selectionSets: Map(0) {},
        fieldSelectionSets: Map(0) {},
        uniqueFields: {},
        nonUniqueFields: {},
        resolvers: Map(0) {},
        delegationPlanBuilder: [Function: memoized]
      },
      User: {
        typeName: 'User',
        targetSubschemas: Map(1) { [Subschema] => [Array] },
        typeMaps: Map(2) {
          [Subschema] => [Object: null prototype],
          [Subschema] => [Object: null prototype]
        },
        selectionSets: Map(1) { [Subschema] => [Object] },
        fieldSelectionSets: Map(0) {},
        uniqueFields: { reviews: [Subschema] },
        nonUniqueFields: {},
        resolvers: Map(1) {
          [Subschema] => [Function: batchMergedTypeResolverWrapper]
        },
        delegationPlanBuilder: [Function: memoized]
      }
    }

Merge types are User and TransactionDecorator but Transaction, CardTransaction and SEPACreditTransferTransaction were listed, not sure why.

},
CardTransaction: {
decorators: (_, { ids }) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong because decorators don't have an argument called ids but it needs id from the parent id

Transaction: {
decorators: (_, { ids }) => {
decorators: ({ id }: { id: string }) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong because there is no argument ids but it needs id from Transaction to fetch decorators

@xharkonen xharkonen closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants