Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test with nested interfaces #6206

Closed
wants to merge 3 commits into from
Closed

Failing test with nested interfaces #6206

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e54395d
Faiing test with nested interfaces
xharkonen May 22, 2024
95840f5
Prettier
ardatan May 22, 2024
68048c8
Fix
ardatan May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 44 additions & 44 deletions packages/stitch/tests/mergeDeepInterfaces.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { graphql } from 'graphql';
import { makeExecutableSchema } from '@graphql-tools/schema';
import { assertSome } from '@graphql-tools/utils';
import { assertSome, ExecutionResult, IResolvers } from '@graphql-tools/utils';
import { stitchSchemas } from '../src/stitchSchemas.js';

const localSchemaGQL = /* GraphQL */ `
Expand Down Expand Up @@ -108,29 +108,11 @@ const decorators = [

const reviews = [{ id: 'tx1', productUpc: '1', userId: '1', body: 'love it' }];

const localResolvers = {
const localResolvers: IResolvers = {
Transaction: {
decorators: (_, { ids }) => {
decorators: ({ id }: { id: string }) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong because there is no argument ids but it needs id from Transaction to fetch decorators

console.log('Transaction decorators');
const result = ids.map(id => decorators.find(d => d.txId === id) || null);
console.log('CardTransaction decorators', result);
return result;
},
},
CardTransaction: {
decorators: (_, { ids }) => {
console.log('CardTransaction decorators');
const result = ids.map(id => decorators.find(d => d.txId === id) || null);
console.log('CardTransaction decorators', result);
return result;
},
},
SEPACreditTransferTransaction: {
decorators: (_, { ids }) => {
console.log('SEPACreditTransferTransaction decorators');
const result = ids.map(id => decorators.find(d => d.txId === id) || null);
console.log('SEPACreditTransferTransaction decorators', result);
return result;
return decorators.filter(d => d.txId === id);
},
},
Review: {
Expand All @@ -140,41 +122,42 @@ const localResolvers = {
reviews: user => reviews.filter(r => r.userId === user.id),
},
Query: {
reviews: (_, { ids }) => {
reviews: (_, { ids }: { ids: string[] }) => {
const result = ids.map(id => reviews.find(r => r.id === id) || null);
console.log('result', result);
return result;
},
_users: (_, { ids }) => ids.map(id => ({ id })),
_transactions: (root, { ids }) => ids.map(id => ({ id })),
_decoratedTransaction: (root, { ids }) => {
_users: (_, { ids }: { ids: string[] }) => ids.map(id => ({ id })),
_transactions: (_, { ids }: { ids: string[] }) =>
ids.map(id => allTransactions.find(t => t.id === id) || null),
_decoratedTransaction: (root, { ids }: { ids: string[] }) => {
console.log('root', root);
console.log('ids', ids);
return root;
},
_decorators: (root, { ids }, context, info) => {
_decorators: (_, { ids }: { ids: string[] }, __, info) => {
const deco = ids.map(id => decorators.find(d => d.txId === id));
console.log('deco result', info, ids, deco);
return deco;
},
transactionDecoratorsById: (root, { id }) => {
transactionDecoratorsById: (_, { id }) => {
const decoResult = decorators.find(m => m.txId === id) || null;
console.log('single', id, decoResult);
return decoResult;
},
transactionDecoratorsByIds: (root, { ids }) => {
transactionDecoratorsByIds: (_, { ids }: { ids: string[] }) => {
const decoResult = ids.map(id => decorators.find(m => m.txId === id) || null);
console.log('transactionDecoratorsByIds', ids, decoResult);
return decoResult;
},
categoryDecoratorsByIds: (root, { ids }) => {
categoryDecoratorsByIds: (_root, { ids }: { ids: string[] }) => {
console.log('ex');
return ids.map(
id =>
decorators.find(m => m.txId === id && m.decorationType === 'CategoryDecorator') || null,
);
},
documentDecoratorsByIds: (root, { ids }) => {
documentDecoratorsByIds: (_root, { ids }: { ids: string[] }) => {
console.log('ex');
return ids.map(
id =>
Expand Down Expand Up @@ -245,19 +228,18 @@ const users = [
{ id: '2', username: 'bigvader23' },
];

const findAccountById = id => accounts.find(account => account.id === id);
const transactionsByAccount = id => allTransactions.filter(tx => tx.accountId === id);
const findTransactionById = id => allTransactions.find(tx => tx.id === id);
const findTransactionByIds = ids => allTransactions.filter(tx => ids.includes(tx.id));
const findAccountById = (id: string) => accounts.find(account => account.id === id);
const transactionsByAccount = (id: string) => allTransactions.filter(tx => tx.accountId === id);
const findTransactionById = (id: string) => allTransactions.find(tx => tx.id === id);

const remoteResolvers = {
const remoteResolvers: IResolvers = {
Account: {
transactions: root => {
return root.transactions;
},
},
Query: {
users: (root, { ids }) => {
users: (_root, { ids }: { ids: string[] }) => {
console.log('query remote users', ids);
const result = ids.map(id => users.find(u => u.id === id) || null);
console.log('result', result);
Expand All @@ -279,12 +261,12 @@ const remoteResolvers = {
transaction: (_root, { id }) => {
return findTransactionById(id);
},
transactions: (_root, { ids }) => {
transactions: (_root, { ids }: { ids: string[] }) => {
const result = {
totalCount: allTransactions.length,
edges: ids
.map(id => allTransactions.find(t => t.id === id))
.map(tx => ({ node: tx, cursor: tx.id })),
.map(tx => ({ node: tx, cursor: tx?.id })),
};
return result;
},
Expand Down Expand Up @@ -350,7 +332,11 @@ const remoteSchemaGQL = /* GraphQL */ `
}
`;

const localSchema = makeExecutableSchema({ typeDefs: localSchemaGQL, resolvers: localResolvers });
const localSchema = makeExecutableSchema({
typeDefs: localSchemaGQL,
resolvers: localResolvers,
inheritResolversFromInterfaces: true,
});
const remoteSchema = makeExecutableSchema({
typeDefs: remoteSchemaGQL,
resolvers: remoteResolvers,
Expand All @@ -363,9 +349,21 @@ describe('merged deep interfaces', () => {
schema: localSchema,
batch: true,
merge: {
TransactionDecorator: {
SEPACreditTransferTransaction: {
xharkonen marked this conversation as resolved.
Show resolved Hide resolved
selectionSet: '{ id }',
fieldName: '_transactions',
key: ({ id }) => {
console.log('x id', id);
return id;
},
argsFromKeys: ids => {
console.log('x', ids);
return { ids };
},
},
CardTransaction: {
selectionSet: '{ id }',
fieldName: '_decorators',
fieldName: '_transactions',
key: ({ id }) => {
console.log('x id', id);
return id;
Expand All @@ -389,8 +387,8 @@ describe('merged deep interfaces', () => {
],
});

test.only('should resolve the list of types of the interface', async () => {
const result = await graphql({
test('should resolve the list of types of the interface', async () => {
const result: ExecutionResult<any> = await graphql({
schema: stitchedSchema,
source: /* GraphQL */ `
query {
Expand All @@ -403,13 +401,15 @@ describe('merged deep interfaces', () => {
id
accountId
decorators {
__typename
id
}
}
... on SEPACreditTransferTransaction {
id
accountId
decorators {
__typename
id
}
}
Expand Down
Loading