Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes per WPT tests #1219

Merged
merged 2 commits into from Mar 22, 2024
Merged

Fixes per WPT tests #1219

merged 2 commits into from Mar 22, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Mar 21, 2024

No description provided.

Copy link

codesandbox bot commented Mar 21, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@ardatan ardatan marked this pull request as ready for review March 21, 2024 13:47
@ardatan ardatan changed the title Fixes per WPT tests WIP: Fixes per WPT tests Mar 21, 2024
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/node-fetch 0.5.10-alpha-20240321134843-2ae7764efe55eb7970cab335a048aebb4a6d3b0f npm ↗︎ unpkg ↗︎

Copy link
Contributor

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=139.638716 min=12     med=139     max=196      p(90)=161     p(95)=167    
     data_received..................: 24 MB  800 kB/s
     data_sent......................: 16 MB  518 kB/s
     http_req_blocked...............: avg=2.71µs     min=702ns  med=1.37µs  max=8.67ms   p(90)=1.97µs  p(95)=2.19µs 
     http_req_connecting............: avg=822ns      min=0s     med=0s      max=6.36ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=19.05ms    min=1.68ms med=18.65ms max=847.85ms p(90)=24.82ms p(95)=26.07ms
       { expected_response:true }...: avg=19.05ms    min=1.68ms med=18.65ms max=847.85ms p(90)=24.82ms p(95)=26.07ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 156963
     http_req_receiving.............: avg=35.8µs     min=8.89µs med=25.37µs max=21.05ms  p(90)=40.62µs p(95)=49.2µs 
     http_req_sending...............: avg=10.23µs    min=2.78µs med=5.86µs  max=23.43ms  p(90)=8.85µs  p(95)=13.52µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=19.01ms    min=1.64ms med=18.6ms  max=847.8ms  p(90)=24.78ms p(95)=26.01ms
     http_reqs......................: 156963 5231.125165/s
     iteration_duration.............: avg=38.2ms     min=9.59ms med=37.25ms max=867.42ms p(90)=41.54ms p(95)=46.35ms
     iterations.....................: 78459  2614.812722/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.141473 min=14      med=141     max=197     p(90)=158     p(95)=163    
     data_received..................: 21 MB  707 kB/s
     data_sent......................: 14 MB  453 kB/s
     http_req_blocked...............: avg=4.37µs     min=711ns   med=1.45µs  max=10.86ms p(90)=2.13µs  p(95)=2.41µs 
     http_req_connecting............: avg=2.46µs     min=0s      med=0s      max=10.55ms p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.57ms    min=3.31ms  med=21.13ms max=1.02s   p(90)=27.26ms p(95)=28.9ms 
       { expected_response:true }...: avg=21.57ms    min=3.31ms  med=21.13ms max=1.02s   p(90)=27.26ms p(95)=28.9ms 
     http_req_failed................: 0.00%  ✓ 0           ✗ 138597
     http_req_receiving.............: avg=37.18µs    min=10.13µs med=28.32µs max=20.78ms p(90)=43.57µs p(95)=51.67µs
     http_req_sending...............: avg=10.98µs    min=3.44µs  med=7.09µs  max=13.18ms p(90)=10.06µs p(95)=13.69µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.52ms    min=3.29ms  med=21.09ms max=1.02s   p(90)=27.21ms p(95)=28.85ms
     http_reqs......................: 138597 4618.868157/s
     iteration_duration.............: avg=43.24ms    min=11.94ms med=41.94ms max=1.04s   p(90)=46.62ms p(95)=52.85ms
     iterations.....................: 69278  2308.750898/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 308986      ✗ 0     
     data_received..................: 30 MB   1.0 MB/s
     data_sent......................: 12 MB   412 kB/s
     http_req_blocked...............: avg=1.36µs   min=802ns    med=1.11µs   max=6.36ms   p(90)=1.76µs   p(95)=1.92µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=122.58µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=135.21µs min=90.9µs   med=130.79µs max=6.91ms   p(90)=152.39µs p(95)=159.42µs
       { expected_response:true }...: avg=135.21µs min=90.9µs   med=130.79µs max=6.91ms   p(90)=152.39µs p(95)=159.42µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 154493
     http_req_receiving.............: avg=24.74µs  min=12.73µs  med=23.5µs   max=1.08ms   p(90)=30.47µs  p(95)=32.45µs 
     http_req_sending...............: avg=5.56µs   min=3.51µs   med=4.82µs   max=4.32ms   p(90)=7.26µs   p(95)=7.63µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=104.9µs  min=68.36µs  med=100.07µs max=6.46ms   p(90)=118.9µs  p(95)=124.51µs
     http_reqs......................: 154493  5149.732741/s
     iteration_duration.............: avg=188.66µs min=132.48µs med=182.94µs max=7.11ms   p(90)=208.03µs p(95)=216.69µs
     iterations.....................: 154493  5149.732741/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan changed the title WIP: Fixes per WPT tests Fixes per WPT tests Mar 22, 2024
@ardatan ardatan merged commit fa097a4 into master Mar 22, 2024
21 checks passed
@ardatan ardatan deleted the spec-fixes branch March 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant